Re: Bug Fix: COLLATE with multiple ORDER BYs in aggregates

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: David Fetter <david(at)fetter(dot)org>
Cc: PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Bug Fix: COLLATE with multiple ORDER BYs in aggregates
Date: 2013-04-25 17:42:32
Message-ID: 13551.1366911752@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

David Fetter <david(at)fetter(dot)org> writes:
> While testing the upcoming FILTER clause for aggregates, Erik Rijkers
> uncovered a long-standing bug in $subject, namely that this case
> wasn't handled. Please find attached a patch by Andrew Gierth and
> myself which fixes this issue and adds a regression test to ensure it
> remains fixed.

I don't find this patch to be a good idea.

The argument for it seems to be that

array_agg(a COLLATE "C" ORDER BY b COLLATE "POSIX")

should not throw an error, but why not? And what does that have to do
with whacking around the code for CASE?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2013-04-25 17:55:19 Re: Bug Fix: COLLATE with multiple ORDER BYs in aggregates
Previous Message Andres Freund 2013-04-25 17:34:46 Re: [HACKERS] Simultaneous index creates on different schemas cause deadlock?