| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Boszormenyi Zoltan <zb(at)cybertec(dot)at> |
| Cc: | Amit Kapila <amit(dot)kapila(at)huawei(dot)com>, 'Hans-Jürgen Schönig' <hs(at)cybertec(dot)at>, 'Pg Hackers' <pgsql-hackers(at)postgresql(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Make pg_basebackup configure and start standby [Review] |
| Date: | 2012-10-04 03:24:31 |
| Message-ID: | 1349321071.23971.0.camel@vanquo.pezone.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 2012-10-03 at 18:15 +0200, Boszormenyi Zoltan wrote:
> The second generation of this work is now attached and contains a new
> feature as was discussed and suggested by Magnus Hagander, Fujii Masao
> and Peter Eisentraut. So libpq has grown a new function:
>
> +/* return the connection options used by a live connection */
> +extern PQconninfoOption *PQconninfo(PGconn *conn);
>
> This copies all the connection parameters back from the live PGconn
> itself
> so everything that's needed to connect is already validated.
I don't like that this code maintains a second list of all possible
libpq connection parameters. The parameters to add to the connection
string should be driven off the authoritative list in PQconninfoOptions.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2012-10-04 04:27:33 | Re: xmalloc => pg_malloc |
| Previous Message | Tom Lane | 2012-10-04 03:07:51 | Re: Question on "box @> point" using GiST index on boxes |