| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: external_pid_file not removed on postmaster exit |
| Date: | 2012-08-17 05:43:21 |
| Message-ID: | 1345182201.19882.1.camel@vanquo.pezone.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, 2012-07-27 at 08:09 +0300, Peter Eisentraut wrote:
> It seems strange that the external_pid_file is never removed. There is
> even a C comment about it:
>
> /* Should we remove the pid file on postmaster exit? */
>
> I think it should be removed with proc_exit hook just like the main
> postmaster.pid file.
>
> Does anyone remember why this was not done originally or have any
> concerns?
Since that was not the case, I propose the attached patch to unlink the
external pid file.
| Attachment | Content-Type | Size |
|---|---|---|
| pg-unlink-external-pid-file.patch | text/x-patch | 1.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabrízio de Royes Mello | 2012-08-17 13:16:30 | Re: CREATE SCHEMA IF NOT EXISTS |
| Previous Message | Pavel Stehule | 2012-08-17 03:51:35 | Re: review: CHECK FUNCTION statement |