| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Boszormenyi Zoltan <zb(at)cybertec(dot)at> |
| Cc: | Marc Cousin <cousinmarc(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Hans-Juergen Schoenig <hs(at)cybertec(dot)at>, Ants Aasma <ants(at)cybertec(dot)at>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: [PATCH] lock_timeout and common SIGALRM framework |
| Date: | 2012-07-03 21:38:55 |
| Message-ID: | 1341351329-sup-8565@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I don't understand why PGSemaphoreTimedLock() is not broken. I mean
surely you need a bool return to let the caller know whether the
acquisition succeeded or failed? AFAICS you are relying on
get_timeout_indicator() but this seems to me the wrong thing to do ...
(not to mention how ugly it is to percolate through two levels of
abstraction)
--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2012-07-03 21:41:11 | Re: Patch: add conversion from pg_wchar to multibyte |
| Previous Message | Alvaro Herrera | 2012-07-03 21:31:12 | Re: [PATCH] lock_timeout and common SIGALRM framework |