| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Peter Geoghegan <pg(at)bowt(dot)ie>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: pgstat: run pgindent on pgstat.c/h. |
| Date: | 2022-03-19 19:52:15 |
| Message-ID: | 1340428.1647719535@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2022-03-19 12:36:29 -0700, Peter Geoghegan wrote:
>> Ideally there would be some kind of reminder built into the
>> pgindent tooling to make it less likely.
> I think a lot of pgindent runs are just to reindent changes during
> development, so that'd probably just join all the other stuff we learn to
> ignore :)
Yeah ... you can't do anything about it at the time you run pgindent,
because you don't yet have the commit hash. So I don't see that such
a reminder will help much. The pgindent/README file does mention
that you ought to do this, so anyone following that recipe will
get it right.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2022-03-20 09:36:52 | pgsql: Fix global ICU collations for ICU < 54 |
| Previous Message | Peter Geoghegan | 2022-03-19 19:51:53 | Re: pgsql: pgstat: run pgindent on pgstat.c/h. |