| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: RelationGetIndexAttrBitmap comment outdated |
| Date: | 2023-07-12 14:42:48 |
| Message-ID: | 133EC44B-573A-443C-8900-E968AA81EB6B@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 12 Jul 2023, at 16:37, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>
> I realized that commit 19d8e2308bc5 (and 5753d4ee320b before that) added
> a new output type to RelationGetIndexAttrBitmap but forgot to list its
> effect in the function's documenting comment. Here's a patch that
> updates it, making it more specific (and IMO more readable). I also add
> a comment to the enum definition, to remind people that the other one
> needs to be modified.
LGTM, a clear improvement.
> This ought to be backpatched to 16.
+1
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Önder Kalacı | 2023-07-12 14:44:39 | Re: [Patch] Use *other* indexes on the subscriber when REPLICA IDENTITY is FULL |
| Previous Message | Alvaro Herrera | 2023-07-12 14:37:16 | RelationGetIndexAttrBitmap comment outdated |