| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | errdetail_busy_db plural forms |
| Date: | 2012-06-13 09:16:01 |
| Message-ID: | 1339578961.11971.25.camel@vanquo.pezone.net |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I was looking for missing use of gettext plural forms, which led me to
errdetail_busy_db().
While we can't do much about this:
errdetail("There are %d other session(s) and %d prepared transaction(s) using the database.",
notherbackends, npreparedxacts);
I think it's still worth pluralizing the other cases
errdetail("There are %d other session(s) using the database.",
notherbackends);
and
errdetail("There are %d prepared transaction(s) using the database.",
npreparedxacts);
Especially the "other sessions" case is probably the one most seen by users.
So I propose the attached patch.
| Attachment | Content-Type | Size |
|---|---|---|
| pg-errdetail_busy_db-plurals.patch | text/x-patch | 1.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2012-06-13 09:18:19 | Re: Minimising windows installer password confusion |
| Previous Message | Dave Page | 2012-06-13 09:14:45 | Re: Minimising windows installer password confusion |