Re: Patch for closing frmEditGrid dialog using accelerator

From: "J(dot)F(dot) Oster" <jinfroster(at)mail(dot)ru>
To: Fredrik de Vibe <fdv(at)ifi(dot)uio(dot)no>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: Patch for closing frmEditGrid dialog using accelerator
Date: 2014-06-07 03:57:12
Message-ID: 1338107886.20140607075712@mail.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hello Fredrik,

+1 for Ctrl-W.

I've made the same change :)
Didn't post it because of another patch in review queue.

Saturday, June 7, 2014, 1:58:55 AM, Fredrik de Vibe wrote:

FdV> I've been using pgadmin3 for some time, and while I really appreciate
FdV> the tool, I've found it to be a *slight* nuisance that there is no
FdV> accelerator defined for closing the "View Data" dialog ("frmEditGrid").
FdV> While I agree this is a trivial issue, adding this feature would improve
FdV> the user experience as well as make it more consistent (the query dialog
FdV> has this feature). Please see the attached patch for details.

FdV> I also noticed that there *is* an accelerator defined for saving, but
FdV> it's not shown in the menu element. This is included in the patch.

--
Best regards,
J.F.

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message J.F. Oster 2014-06-07 04:28:30 PATCH: Search Objects by definitions and comments
Previous Message Fredrik de Vibe 2014-06-06 21:58:55 Patch for closing frmEditGrid dialog using accelerator