plperl_helpers.h fix for clang

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Alex Hunsaker <badalex(at)gmail(dot)com>
Subject: plperl_helpers.h fix for clang
Date: 2012-05-24 17:19:21
Message-ID: 1337879961.17469.5.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

clang warns about that newish SvREFCNT_inc(sv) call in plperl_helpers.h
about an unused return value, because the macro expansion of
SvREFCNT_inc(sv) returns sv. The merit of that warning might be
debatable, but it seems easy to fix by using SvREFCNT_inc_void(sv)
instead.

And we could use SvREFCNT_inc_simple_void(sv), since sv doesn't have any
side effects, but that's optional.

Any concerns?

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2012-05-24 17:25:58 Re: [RFC] Interface of Row Level Security
Previous Message Robert Haas 2012-05-24 17:12:58 Re: [RFC] Interface of Row Level Security