Re: Archiver not exiting upon crash

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Archiver not exiting upon crash
Date: 2012-05-23 16:13:52
Message-ID: 1337789632.23660.2.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On mån, 2012-05-21 at 13:14 -0400, Tom Lane wrote:
> > ... but having said that, I see Peter's commit
> > d6de43099ac0bddb4b1da40088487616da892164 only touched postgres.c's
> > quickdie(), and not all the *other* background processes with
> identical
> > coding. That seems a clear oversight, so I will go fix it. Doesn't
> > explain why the archiver would get confused, though, since that file
> > doesn't have any code that tries to re-enable signals after entering
> the
> > signal handler.
>
> ... wait, scratch that. AFAICS, that commit was totally useless,
> because BlockSig should always already contain SIGQUIT.

No, because PostgresMain() deletes it from BlockSig.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2012-05-23 16:26:31 Re: Archiver not exiting upon crash
Previous Message Peter Eisentraut 2012-05-23 16:12:26 Re: Archiver not exiting upon crash