Re: pg_upgrade and pg_config dependency

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_upgrade and pg_config dependency
Date: 2012-03-16 23:11:17
Message-ID: 1331939378-sup-3777@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Excerpts from Bruce Momjian's message of vie mar 16 20:06:28 -0300 2012:
> Àlvaro told me he got a Spanish-language report that pg_upgrade
> failed because it required pg_config, and pg_config is only supplied
> with the devel packages.
>
> I initially thought that it was a packaging problem, but I later
> realized the pg_config is mostly developer settings, and that using
> pg_config was not getting any change to libdir by dynamic_library_path
> in postgresql.conf, and that I should just merge the pg_upgrade_support
> detection code into the existing shared library detection "LOAD" code I
> already had.
>
> This avoids the pg_config dependency, works better for libdir, and
> reduces the amount of code.

Bruce also found a reference to this old bug report:
http://archives.postgresql.org/pgsql-bugs/2011-12/msg00254.php
This includes a link to a Debian bug report by Peter.

> Patch attached. Should this be backpatched to PG 9.1; I think so.

+1

--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Davis 2012-03-16 23:29:58 Re: Storage Manager crash at mdwrite()
Previous Message Bruce Momjian 2012-03-16 23:06:28 pg_upgrade and pg_config dependency