Re: pg_stats_recovery view

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Jaime Casanova <jaime(at)2ndquadrant(dot)com>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Bernd Helmle <mailings(at)oopsware(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_stats_recovery view
Date: 2012-02-14 11:40:35
Message-ID: 1329219548-sup-6185@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Excerpts from Jaime Casanova's message of mar feb 14 04:10:58 -0300 2012:
> On Thu, Feb 2, 2012 at 2:32 AM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> >
> > I haven't looked through the code in detail, but one direct comment:
> > do we really need/want to send this through the stats collector? It
> > will only ever have one sender - perhaps we should just either store
> > it in shared memory or store it locally and only send it on demand?
> >
>
> fyi, i intend to send a reworked patch later today, it will store the
> info locally and send it on demand.
> about the _short_desc functions, i added that because i wanted to
> understand what was happening during recovery and the wal_record_type
> (xl_info) being a number is not that clear

Maybe it'd be clearer if you display it in hex and filter out just the
bits that are interesting for this use? IIRC xl_info carries some other
bits than the ones to identify the record type, which could be
confusing.

--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2012-02-14 13:19:26 Re: [v9.2] LEAKPROOF attribute of FUNCTION (Re: [v9.2] Fix Leaky View Problem)
Previous Message Etsuro Fujita 2012-02-14 11:40:27 Re: pgsql_fdw, FDW for PostgreSQL server