From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [COMMITTERS] pgsql: Add new keywords SNAPSHOT and TYPES to the keyword list in gram. |
Date: | 2012-02-09 18:25:53 |
Message-ID: | 1328811484-sup-8240@alvh.no-ip.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Excerpts from Tom Lane's message of jue feb 09 12:17:59 -0300 2012:
>
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > Excerpts from Heikki Linnakangas's message of jue feb 09 06:42:12 -0300 2012:
> >> src/tools/check_keywords.pl is your friend.
>
> > I wondered a couple of weeks ago if we could, instead, generate the
> > lists in gram.y from kwlist.h.
>
> We've looked into that in the past. bison does not seem to have any
> sort of "include" directive, which means the only way to do it would be
> to have the gram.y file be built from pieces at compile time.
Doh, bummer.
> Although
> Michael is successfully doing something of the sort for ecpg, I find it
> way too ugly in return for the amount of benefit we'd get.
Agreed.
> If people are sufficiently worried about this, a better answer would be
> to teach the makefiles to run check_keywords.pl during every build.
FWIW that script is throwing a warning here:
Use of assignment to $[ is deprecated at /pgsql/source/HEAD/src/tools/check_keywords.pl line 19.
Also, we should at least do the attached to simplify the process.
--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
Attachment | Content-Type | Size |
---|---|---|
check-keywords.patch | application/octet-stream | 406 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2012-02-09 18:30:27 | Re: [COMMITTERS] pgsql: Add new keywords SNAPSHOT and TYPES to the keyword list in gram. |
Previous Message | Peter Eisentraut | 2012-02-09 18:20:56 | pgsql: psql: Support zero byte field and record separators |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2012-02-09 18:30:27 | Re: [COMMITTERS] pgsql: Add new keywords SNAPSHOT and TYPES to the keyword list in gram. |
Previous Message | Tom Lane | 2012-02-09 18:22:47 | Re: Notify system doesn't recover from "No space" error |