| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: hiding variable-length fields from Form_pg_* structs |
| Date: | 2012-01-26 18:01:21 |
| Message-ID: | 1327600881.26839.3.camel@vanquo.pezone.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On mån, 2012-01-09 at 14:04 -0500, Tom Lane wrote:
> #ifdef CATALOG_VARLEN /* variable-length fields start here
> */
>
> to be even clearer.
>
> What would be appropriate to add instead of those inconsistently-used
> comments is explicit comments about the exception cases such as
> proargtypes, to make it clear that the placement of the #ifdef
> CATALOG_VARLEN is intentional and not a bug in those cases.
>
I implemented your suggestions in the attached patch.
| Attachment | Content-Type | Size |
|---|---|---|
| catalog-varlen.patch | text/x-patch | 23.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Vik Reykja | 2012-01-26 18:13:17 | Re: Different error messages executing CREATE TABLE or ALTER TABLE to create a column "xmin" |
| Previous Message | Robert Haas | 2012-01-26 17:54:08 | Re: Configuring Postgres to Add A New Source File |