Re: hiding variable-length fields from Form_pg_* structs

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: hiding variable-length fields from Form_pg_* structs
Date: 2012-01-09 18:47:35
Message-ID: 1326134855.12723.8.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

So here is a patch for that.

There are a few cases that break when hiding all variable length fields:

Access to indclass in relcache.c, as discussed upthread, which should be
fixed.

Access to pg_largeobject.data. This is apparently OK, per comment in
inv_api.c.

Access to pg_proc.proargtypes in various places. This is clearly
useful, so we'll keep it visible.

So I think the relcache.c thing should be fixed and then this might be
good to go.

Attachment Content-Type Size
catalog-varlen.patch text/x-patch 18.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2012-01-09 19:04:59 Re: hiding variable-length fields from Form_pg_* structs
Previous Message Heikki Linnakangas 2012-01-09 18:39:34 Re: Why is CF 2011-11 still listed as "In Progress"?