Re: Escaping ":" in .pgpass - code or docs bug?

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Richard Huxton <dev(at)archonet(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Ross Reedstrom <reedstrm(at)rice(dot)edu>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Escaping ":" in .pgpass - code or docs bug?
Date: 2011-12-19 19:42:18
Message-ID: 1324323646-sup-3128@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Excerpts from Richard Huxton's message of lun dic 19 16:33:31 -0300 2011:
> On 19/12/11 16:48, Robert Haas wrote:
> > On Sat, Dec 17, 2011 at 3:27 AM, Ross Reedstrom<reedstrm(at)rice(dot)edu> wrote:
> >> This should either be fixed by changing the documentation to say to not escape
> >> colons or backslashes in the password part, only, or modify this function
> >> (PasswordFromFile) to silently unescape the password string. It already copies
> >> it.
> >
> > My vote is for a doc correction in the back-branches and a behavior
> > change in master.
>
> Seems sensible - presumably mentioning "this will be corrected in 9.2"?
>
> It's clearly not what you'd call "urgent" since nobody else seems to
> have noticed before now.

Yeah, it is a pretty old bug -- this code was clearly written by some
rookie that didn't know very well what he was doing.

--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2011-12-19 19:43:51 Re: Autonomous subtransactions
Previous Message Richard Huxton 2011-12-19 19:33:31 Re: Escaping ":" in .pgpass - code or docs bug?