Re: pgAdmin 1.14 bug

On Fri, 2011-12-09 at 09:41 +0100, Guillaume Lelarge wrote:
> On Fri, 2011-12-09 at 09:42 +0200, Julius Tuskenis wrote:
> > On 2011.12.08 23:50, Guillaume Lelarge wrote:
> > >> I can confirm the problem.
> > >>
> > >> WinXP SP3, pgAdmin 1.14.0, PostgreSQL 8.3.4 on i686-pc-linux-gnu,
> > >> compiled by GCC gcc (Gentoo 4.3.2-r3 p1.6, pie-10.1.5) 4.3.2
> > >>
> > >> What I noticed is the check constraint is beeing updated even if nothing
> > >> was done to it. I only added a comment ant thats the SQL that was generated:
> > >>
> > >> ALTER TABLE pos_documents DROP CONSTRAINT ck_pos_documents_1;
> > >> ALTER TABLE pos_documents ADD CONSTRAINT ck_pos_documents_1 CHECK
> > >> entry_type::text = 'Z-report open'::text OR entry_type::text =
> > >> 'Return'::text OR entry_type::text = 'Inkasso'::text OR entry_type::text
> > >> = 'Sale'::text OR entry_type::text = 'X-report'::text OR
> > >> entry_type::text = 'Cash Withdrawal'::text OR entry_type::text =
> > >> 'Z-report closed'::text OR entry_type::text = 'Open drawer'::text OR
> > >> entry_type::text = 'Service'::text OR entry_type::text = 'Z-report
> > >> Z1'::text OR entry_type::text = 'Z-report Z2'::text OR entry_type::text
> > >> = 'Z-report Z3'::text OR entry_type::text = ';
> > >> COMMENT ON TABLE pos_documents
> > >> IS 'test';
> > >>
> > >> You can see that the constraint text got truncated and left quotes open.
> > >>
> > > Works fine for me. Dave also. I guess we both use 1.14.1, and you both
> > > use 1.14.0. Update to 1.14.1 might fix your issue.
> > Updated the pgAdmin to 1.14.1 yet the error is the same... Nothing has
> > changed concerning the issue - I still get the SQL I have sent before
> > when editing the comment. I think the problem.
> >
> > I have checked and there is no problem with short check rules. You can
> > see, from the SQL I have sent that the constraint text is truncated to
> > 512 char (when counting from "entry_type"). That could indicate a
> > problem in table properties dialog window....
>
> We don't set length of strings, so I don't see why a truncate would
> happen. It could be a platform issue. I'll try on Windows (I checked on
> Linux, and I suppose Dave checked on Mac OS X, but you both are using
> Windows).
>

It seems wxListCtrl's cells have a limit on the number of characters on
Windows. It's 512, as Julius rightly guessed.

I've fixed the issue for the constraints list control, but I guess we
need to review our use of that control. Sighhh.

Anyway, this fix will be available with pgAdmin 1.14.2.

--
Guillaume
http://blog.guillaume.lelarge.info
http://www.dalibo.com