| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Martin Pihlak <martin(dot)pihlak(at)gmail(dot)com>, Volkan YAZICI <yazicivo(at)ttmail(dot)com>, pgsql-patches(at)postgresql(dot)org, postgres(at)cybertec(dot)at |
| Subject: | Re: stored procedure stats in collector |
| Date: | 2008-05-14 06:16:04 |
| Message-ID: | 13229.1210745764@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Magnus Hagander <magnus(at)hagander(dot)net> writes:
> Tom Lane wrote:
>> Huh ... I'd forgotten about that ... although it seems to work only for
>> rather small values of "work", since the WIN32 code path isn't paying
>> attention to the "who" argument.
> True, but it works for this case :-)
Shouldn't we at least make it fail with EINVAL if "who" doesn't match
whichever semantics this code is able to implement?
[ not relevant to the immediate patch, I suppose, but it might save some
tears later. ]
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2008-05-14 06:18:06 | Re: stored procedure stats in collector |
| Previous Message | Magnus Hagander | 2008-05-14 06:07:54 | Re: stored procedure stats in collector |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2008-05-14 06:18:06 | Re: stored procedure stats in collector |
| Previous Message | Magnus Hagander | 2008-05-14 06:07:54 | Re: stored procedure stats in collector |