Re: pgsql: pg_dump: Add gettext plural support to error message

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: pg_dump: Add gettext plural support to error message
Date: 2011-11-29 20:02:20
Message-ID: 1322596940.7093.2.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On tis, 2011-11-29 at 14:48 -0500, Tom Lane wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> > pg_dump: Add gettext plural support to error message
>
> Er, what for? The case n=1 is explicitly excluded.

Because other languages have more than one plural form. It's the same
reason why we have

if (ntups != 1)
{
write_msg(NULL, ngettext("query returned %d row instead of one: %s\n",
"query returned %d rows instead of one: %s\n",
ntups),
ntups, upgrade_query->data);
exit_nicely();
}

etc.

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2011-11-29 20:03:17 pgsql: When a row fails a CHECK constraint, show row's contents in errd
Previous Message Tom Lane 2011-11-29 19:48:34 Re: pgsql: pg_dump: Add gettext plural support to error message