| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: strtoll/strtoull emulation |
| Date: | 2014-06-03 14:55:17 |
| Message-ID: | 13197.1401807317@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> I recently had the need to use strtoull() in postgres code. Only to
> discover that that's not available on some platforms. IIRC windows/msvc
> was one of them. Now 9d7ded0f4277f5c0063eca8e871a34e2355a8371 added
> another user - guarded by HAVE_STRTOULL. That commit will make things
> worse on windows btw...
Worse than what? AFAICT, the old code would produce complete garbage
on Windows. The new code at least gives the right answer for rowcounts
up to 4GB.
> How about adding emulation for strtoll/strtoull to port/? The BSDs have
> easily crib-able functions available...
Ugh. Surely Windows has got *some* equivalent, perhaps named differently?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Gurjeet Singh | 2014-06-03 14:56:42 | Re: Proposing pg_hibernate |
| Previous Message | Magnus Hagander | 2014-06-03 14:53:59 | Re: pg_basebackup failed to back up large file |