Re: Re: [HACKERS] [COMMITTERS] pgsql: Fix TransactionIdIsCurrentTransactionId() to use binary search

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Treat <xzilla(at)users(dot)sourceforge(dot)net>
Cc: pgsql-performance(at)postgresql(dot)org, Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Subject: Re: Re: [HACKERS] [COMMITTERS] pgsql: Fix TransactionIdIsCurrentTransactionId() to use binary search
Date: 2008-04-26 17:26:44
Message-ID: 13180.1209230804@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers pgsql-performance

Robert Treat <xzilla(at)users(dot)sourceforge(dot)net> writes:
> On Friday 25 April 2008 17:32, Tom Lane wrote:
>> Robert Treat <xzilla(at)users(dot)sourceforge(dot)net> writes:
>>> Oddly some dtrace profiling gave me this, which is pretty different, but
>>> certainly doesn't have concerns about TransactionIdIsCurrentTransactionId
>>
>> .... which seems to pretty much destroy your thesis, no?

> How so? Before the patch we bog down for hours, spending 99% of our time in
> TransactionIdIsCurrentTransactionId, after the patch everything performs well
> (really better than before) and we spend so little time in
> TransactionIdIsCurrentTransactionId it barely shows up on the radar.

Oh, you failed to state that the dtrace output was post-patch. You need
to show *pre* patch dtrace output if you want us to think it relevant.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2008-04-26 17:33:01 Re: Re: [COMMITTERS] pgsql: Update: < * Allow adding enumerated values to an existing
Previous Message Andrew Dunstan 2008-04-26 15:18:41 Re: Re: [COMMITTERS] pgsql: Update: < * Allow adding enumerated values to an existing

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-04-26 17:27:50 Re: Proposed patch - psql wraps at window width
Previous Message Joshua D. Drake 2008-04-26 15:54:46 Re: we don't have a bugzilla

Browse pgsql-performance by date

  From Date Subject
Next Message Robert Treat 2008-04-26 18:20:15 Re: Re: [HACKERS] [COMMITTERS] pgsql: Fix TransactionIdIsCurrentTransactionId() to use binary search
Previous Message Luke Lonergan 2008-04-26 16:13:34 Re: Best practice to load a huge table from ORACLE to PG