From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
---|---|
To: | Kevin Grittner <kevin(dot)grittner(at)wicourts(dot)gov> |
Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: have SLRU truncation use callbacks |
Date: | 2011-10-04 17:17:25 |
Message-ID: | 1317748567-sup-1166@alvh.no-ip.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Excerpts from Kevin Grittner's message of jue sep 29 14:51:38 -0300 2011:
> Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>
> > But I think these changes stand on their own, merely on code
> > clarity grounds).
>
> After a quick scan, I think it helps with that. This was a messy
> area to deal with in SSI given the old API; with this change I think
> we could make that part of the SSI code clearer and maybe clean up
> unneeded files in a couple places where cleanup under the old API
> was judged not to be worth the code complexity needed to make it
> happen.
Thanks for the review. I just pushed this. Note I didn't touch the
predicate.c stuff at all -- I leave that to you, if you're so inclined :-)
--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
From | Date | Subject | |
---|---|---|---|
Next Message | Alex Hunsaker | 2011-10-04 17:27:32 | Re: Re: [COMMITTERS] pgsql: Force strings passed to and from plperl to be in UTF8 encoding. |
Previous Message | Dimitri Fontaine | 2011-10-04 16:36:12 | Re: Should we get rid of custom_variable_classes altogether? |