Re: unite recovery.conf and postgresql.conf

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: unite recovery.conf and postgresql.conf
Date: 2011-09-16 12:25:44
Message-ID: 1316175944.14316.14.camel@fsopti579.F-Secure.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On fre, 2011-09-16 at 11:54 +0900, Fujii Masao wrote:
> #1
> Use empty recovery.ready file to enter arhicve recovery. recovery.conf
> is not read automatically. All recovery parameters are expected to be
> specified in postgresql.conf. If you must specify them in recovery.conf,
> you need to add "include 'recovery.conf'" into postgresql.conf. But note
> that that recovery.conf will not be renamed to recovery.done at the
> end of recovery. This is what the patch I've posted does. This is
> simplest approach, but might confuse people who use the tools which
> depend on recovery.conf.

A small variant to this: When you are actually doing recovery from a
backup, having a recovery trigger and a recovery done file is obviously
quite helpful and necessary for safety. But when you're setting up a
replication slave, it adds extra complexity for the user. The
approximately goal ought to be to be able to do

pg_basebackup -h master -D there
postgres -D there --standby-mode=on --primary-conninfo=master

without the need to touch any obscure recovery trigger files.

So perhaps recovery.{trigger,ready} should not be needed if, say,
standby_mode=on. But then what impact should the presence of
recovery.done have?

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dave Page 2011-09-16 12:33:10 Re: Is there really no interest in SQL Standard?
Previous Message Peter Eisentraut 2011-09-16 12:13:07 Re: unite recovery.conf and postgresql.conf