| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com> |
| Cc: | "Wang, Jing" <jingw(at)fast(dot)au(dot)fujitsu(dot)com>, Euler Taveira <euler(at)timbira(dot)com(dot)br>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_dump reporing version of server & pg_dump as comments in the output |
| Date: | 2014-07-07 23:07:04 |
| Message-ID: | 13137.1404774424@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com> writes:
> Can't we remove this else all-together and print extra line unconditionally?
> Also can we remove curly braces in if and else near these code changes ?
> (Attached patch along those lines)
I committed this with slight further rearrangement to create what seems
like better vertical whitespace choices in verbose vs non-verbose cases,
to wit
--
-- PostgreSQL database dump
--
-- Dumped from database version 9.5devel
-- Dumped by pg_dump version 9.5devel
SET statement_timeout = 0;
...
vs
--
-- PostgreSQL database dump
--
-- Dumped from database version 9.5devel
-- Dumped by pg_dump version 9.5devel
-- Started on 2014-07-07 19:05:54 EDT
SET statement_timeout = 0;
...
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2014-07-07 23:25:06 | Re: [REVIEW] Re: Fix xpath() to return namespace definitions |
| Previous Message | Peter Geoghegan | 2014-07-07 21:37:32 | Re: things I learned from working on memory allocation |