Re: per-column FDW options, v5

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Shigeru Hanada <shigeru(dot)hanada(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: per-column FDW options, v5
Date: 2011-08-11 16:04:33
Message-ID: 1313078575-sup-1917@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Excerpts from Robert Haas's message of jue ago 11 11:50:40 -0400 2011:
> 2011/8/9 Shigeru Hanada <shigeru(dot)hanada(at)gmail(dot)com>:

> >>> (3) OPTIONS clause style
> >>> Show FDW options as they were in OPTIONS clause.  Each option is shown
> >>> as "key 'value'", and delimited with ','.
> >>>
> >>>     Ex)
> >>>     FDW Options: delimiter ',', quote ''''
> >>>     #delimiter is a comma, and qutoe is a single-quote

> >> I'm against #2, but I could go either way on #1 vs. #3.  If you pick
> >> #3, would you also change the column options to be displayed that way,
> >> or would we end up with table and column options displayed
> >> differently?
> >
> > I'd like to pick #3, and also change per-column options format.  In
> > addition, I'd like to change options format for other FDW objects such
> > as wrappers, servers and user mappings for consistency.  Of course, only
> > if it's acceptable to break backward compatibility...
>
> I think it's fine to change the display format. We haven't had these
> features for very long, so users hopefully shouldn't be expecting that
> everything is set in stone. We have made far bigger changes to
> backslash commands that have been around for far longer (\df, I'm
> looking at you).

We've never promised that backslash commands behave identically across
releases. I think they are more for human consumption than machine, so
why would we care about changing one of them a bit?

--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2011-08-11 16:05:58 Re: per-column FDW options, v5
Previous Message Jean-Baptiste Quenot 2011-08-11 16:01:35 plpython crash