Re: pgsql: Avoid tricky race condition recording XLOG_HINT

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Simon Riggs <simon(at)2ndQuadrant(dot)com>
Cc: pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Avoid tricky race condition recording XLOG_HINT
Date: 2013-04-08 14:47:50
Message-ID: 13130.1365432470@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
> On 8 April 2013 15:29, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Just for the record, the right way to handle that kind of change is to
>> change XLOG_PAGE_MAGIC, not catversion. A database's catalog version
>> might not be available to code that is inspecting WAL files and would
>> like to know what format it should expect.

> I was so happy Andres had remembered to bump the catversion like I often
> do, it didn't occur to me it was the wrong one. My bad, sorry.

No problem. XLOG_PAGE_MAGIC is already different from what it was in
9.2, so it's mostly academic whether or not we bump it again during
the devel cycle.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2013-04-08 14:54:03 Re: pgsql: Avoid tricky race condition recording XLOG_HINT
Previous Message Simon Riggs 2013-04-08 14:42:40 Re: pgsql: Avoid tricky race condition recording XLOG_HINT