| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
| Subject: | Re: Compiler warnings with stringRelOpts (was WIP: Fast GiST index build) |
| Date: | 2011-08-09 15:04:31 |
| Message-ID: | 1312902191-sup-9242@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Excerpts from Heikki Linnakangas's message of mar ago 09 08:32:43 -0400 2011:
> On 09.08.2011 13:25, Heikki Linnakangas wrote:
> > On 08.08.2011 22:11, Alvaro Herrera wrote:
> >> Perhaps the easiest way to fix it is as you suggest, by declaring the
> >> struct to take a pointer rather than the value directly. Not sure how
> >> to make both cases work sanely; the add_string_reloption path will need
> >> updates.
> >
> > Agreed, I propose the attached patch to do that.
>
> Committed this.
Thanks.
I think I vaguely remember that the reason for doing it this way is that
the copy into the relcache worked, i.e. if the originals went away,
there was no dangling pointer. Did you test this?
--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2011-08-09 15:20:33 | Re: Enforcing that all WAL has been replayed after restoring from backup |
| Previous Message | Kevin Grittner | 2011-08-09 14:53:37 | Re: WIP fix proposal for bug #6123 |