Re: SSI error messages

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: SSI error messages
Date: 2011-07-27 20:19:22
Message-ID: 1311797962.5508.1.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On lör, 2011-07-16 at 15:01 -0400, Tom Lane wrote:
> Well, as I mentioned in the commit message, I've thought for some time
> that there were use cases for errdetail_internal. Whether these
> particular places in predicate.c use it or not doesn't affect that.

Looking at commit 1af37ec96d97722aeb527f5f43d6f6f2304f0861, not all of
these are strings that don't need to be translated. For example, you
can't assume that the translation of "%s: %s" is "%s: %s" or that the
translation of "%s (%x)" is "%s (%x)". I'll review those in detail when
I find some time, but some of them will probably have to be reverted.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2011-07-27 20:20:35 Re: Check constraints on partition parents only?
Previous Message Andrew Dunstan 2011-07-27 20:17:43 Re: Check constraints on partition parents only?