Re: Re: [COMMITTERS] pgsql: Add temp_file_limit GUC parameter to constrain temporary file sp

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org>
Subject: Re: Re: [COMMITTERS] pgsql: Add temp_file_limit GUC parameter to constrain temporary file sp
Date: 2011-07-18 10:52:50
Message-ID: 1310986371.619.0.camel@fsopti579.F-Secure.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On sön, 2011-07-17 at 18:39 -0400, Bruce Momjian wrote:
> Tom Lane wrote:
> > Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > > Tom Lane wrote:
> > >> Add temp_file_limit GUC parameter to constrain temporary file space usage.
> > >>
> > >> The limit is enforced against the total amount of temp file space used by
> > >> each session.
> > >>
> > >> Mark Kirkwood, reviewed by C?dric Villemain and Tatsuo Ishii
> >
> > > Should we document that sessions that exceed this limit generate an
> > > error? I don't see any mention of this in the docs.
> >
> > Huh? Seems like a waste of text to me. What else would happen?
>
> Well, if we exceed work_mem, we spill to temp disk. If we exceed temp
> disk, we error out. Those different behaviors don't seem obvious to me.
> The work_mem docs do mention is spills to disk though, so maybe it is
> OK.

Sounds like it would be good to document the behavior if the limit is
exceeded in each case.

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2011-07-18 14:36:07 Re: Re: [COMMITTERS] pgsql: Add temp_file_limit GUC parameter to constrain temporary file sp
Previous Message Robert Haas 2011-07-18 04:50:15 pgsql: Create a "fast path" for acquiring weak relation locks.

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2011-07-18 13:12:20 Reduced power consumption in autovacuum launcher process
Previous Message Pavel Golub 2011-07-18 10:38:37 Re: fixing PQsetvalue()