From: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
---|---|
To: | Thom Brown <thom(at)linux(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [FEATURE] Add schema option to all relevant objects |
Date: | 2011-07-09 08:23:57 |
Message-ID: | 1310199837.2101.1.camel@laptop |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
On Sat, 2011-07-09 at 01:15 +0200, Guillaume Lelarge wrote:
> On Sat, 2011-07-09 at 00:12 +0100, Thom Brown wrote:
> > On 8 July 2011 20:57, Guillaume Lelarge <guillaume(at)lelarge(dot)info> wrote:
> > > It's not easy to do, I understand you got carried away. Happened
> > > sometimes to me too. Still happens actually.
> >
> > Found out this patch doesn't contain my removal of a duplicate section
> > of code in dlgTextSearchConfiguration.cpp, so now if the name of a
> > text search configuration is changed, it appears in the SQL output
> > twice. My original patch moved a whole section of code, but now the
> > removal of the original copy is missing. Everything else seems to
> > work fine though.
> >
>
> Will look into that tomorrow. Right now, I need some sleep :)
>
You're right. I saw it on the diff as rejected, and couldn't understand
why you deleted that part. And I thought it was probably because of an
already applied patch (just like the changes on
pgadmin/schema/pgIndex.cpp).
Anyway, I re-added your code.
--
Guillaume
http://blog.guillaume.lelarge.info
http://www.dalibo.com
From | Date | Subject | |
---|---|---|---|
Next Message | Guillaume Lelarge | 2011-07-09 08:28:21 | Re: [FEATURE] Add schema option to all relevant objects |
Previous Message | Thom Brown | 2011-07-08 23:23:54 | Re: [FEATURE] Add schema option to all relevant objects |