Re: Re: PG regression with row comparison when btree_gist is enabled (BUG)

From: Jeff Davis <pgsql(at)j-davis(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: oleg(at)sai(dot)msu(dot)su, Denis de Bernardy <ddebernardy(at)yahoo(dot)com>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: Re: PG regression with row comparison when btree_gist is enabled (BUG)
Date: 2011-07-06 17:00:11
Message-ID: 1309971611.3012.121.camel@jdavis
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-testers

On Tue, 2011-07-05 at 13:56 -0400, Tom Lane wrote:
> Yeah, I had been thinking along the same lines. It will require
> duplicating the search loop, which is a bit annoying, but perhaps that
> could be factored out as a subroutine.

Patch attached. The logic in predtest.c was a little more complex, and I
don't think we have a lot of test coverage in this area (and I didn't
see an easy way to add many tests), so this will need some review.

Regards,
Jeff Davis

Attachment Content-Type Size
rowcmp2.patch.gz application/x-gzip 1.9 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Jeff Frost 2011-07-06 17:14:41 Re: BUG #6092: specific casting required for gist indexing of bigint
Previous Message Craig Ringer 2011-07-06 11:02:56 Re: R: Re: BUG #6091: Information

Browse pgsql-testers by date

  From Date Subject
Next Message Tom Lane 2011-07-06 17:25:53 Re: Re: PG regression with row comparison when btree_gist is enabled (BUG)
Previous Message Tom Lane 2011-07-05 17:56:21 Re: Re: PG regression with row comparison when btree_gist is enabled (BUG)