gcc 4.6 -Wunused-but-set-variable

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: gcc 4.6 -Wunused-but-set-variable
Date: 2011-06-15 20:23:27
Message-ID: 1308169407.30599.17.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Another set of new gcc 4.6 warnings:

readfuncs.c: In function ‘_readCaseWhen’:
readfuncs.c:875:567: warning: variable ‘token’ set but not used [-Wunused-but-set-variable]
readfuncs.c: In function ‘_readFromExpr’:
readfuncs.c:1159:568: warning: variable ‘token’ set but not used [-Wunused-but-set-variable]

read.c: In function ‘nodeTokenType’:
read.c:222:8: warning: variable ‘val’ set but not used [-Wunused-but-set-variable]

I couldn't see a way good way of programming around this (perhaps in the
second case, but it would get uselessly ugly), so perhaps just marking
the variables as potentially unused would be appropriate? See patch.

Attachment Content-Type Size
gcc-4.6-attribute-unused.patch text/x-patch 831 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dan Ports 2011-06-15 20:28:46 patch: update README-SSI
Previous Message Jaime Casanova 2011-06-15 20:20:59 Re: FK NOT VALID can't be deferrable?