Re: Postmaster holding unlinked files for pg_largeobject table

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Kevin Grittner <kevin(dot)grittner(at)wicourts(dot)gov>, alexk <alexk(at)commandprompt(dot)com>, Alexander Shulgin <ash(at)commandprompt(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Postmaster holding unlinked files for pg_largeobject table
Date: 2011-06-09 20:34:13
Message-ID: 1307651429-sup-8149@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

Excerpts from Alvaro Herrera's message of jue jun 09 16:02:14 -0400 2011:
> Excerpts from Tom Lane's message of jue jun 09 14:45:31 -0400 2011:

> > My thought is that it needs some beta testing. Perhaps it'd be sane to
> > push it into beta2 now, and then back-patch sometime after 9.1 final,
> > if no problems pop up.

> FWIW I was about to push it but noticed that regression tests fail with
> this:
>
> TRAP: FailedAssertion("!(!ReindexIsProcessingIndex(((indexRelation)->rd_id)))", File: "/pgsql/source/HEAD/src/backend/access/index/indexam.c", Line: 283)
>
> I just make distclean'd -- still there. I'm gonna revert my patch and
> retry.

That was pretty weird. I had rm'd the build tree and rebuilt, failure
still there. I then did a git reset FETCH_HEAD, recompiled, and the
problem was gone. git reset to my revision, failed. Then git clean
-dfx, nuked the build tree, redid the whole thing from scratch, no
problem. I guess there was a mismatch on the files that we build in the
source tree.

I have pushed it now.

--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Tom Lane 2011-06-09 20:41:03 Re: Postmaster holding unlinked files for pg_largeobject table
Previous Message Alvaro Herrera 2011-06-09 20:02:14 Re: Postmaster holding unlinked files for pg_largeobject table

Browse pgsql-hackers by date

  From Date Subject
Next Message Merlin Moncure 2011-06-09 20:40:08 Re: Error in PQsetvalue
Previous Message Kevin Grittner 2011-06-09 20:33:25 Re: SSI work for 9.1