| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: inconvenient compression options in pg_basebackup |
| Date: | 2011-05-24 18:40:35 |
| Message-ID: | 1306262435.14693.2.camel@vanquo.pezone.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On sön, 2011-05-22 at 16:43 -0400, Magnus Hagander wrote:
> On Fri, May 20, 2011 at 17:45, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> > On fre, 2011-05-20 at 14:19 -0400, Magnus Hagander wrote:
> >> > I suggest we add an argument-less option -z that means "compress",
> >> and
> >> > then -Z can be relegated to choosing the compression level.
> >>
> >> We can't just use -Z without a parameter for that?
> >
> > You can't portably have a command-line option with an optional argument.
>
> Ugh.
>
> In that case, I'm fine with your suggestion.
Quick patch for verification. I chose the naming -z/--gzip to mirror
GNU tar.
| Attachment | Content-Type | Size |
|---|---|---|
| pg_basebackup-compress.patch | text/x-patch | 5.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2011-05-24 18:48:36 | Re: Adding an example for replication configuration to pg_hba.conf |
| Previous Message | Tom Lane | 2011-05-24 18:40:17 | Re: Alignment padding bytes in arrays vs the planner |