Re: Recommend wrappers of PG_DETOAST_DATUM_PACKED()

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Noah Misch <noah(at)leadboat(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Recommend wrappers of PG_DETOAST_DATUM_PACKED()
Date: 2016-10-25 15:03:13
Message-ID: 13059.1477407793@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Noah Misch <noah(at)leadboat(dot)com> writes:
> When commit 3e23b68dac006e8deb0afa327e855258df8de064 introduced single-byte
> varlena headers, its fmgr.h changes presented PG_GETARG_TEXT_PP() and
> PG_GETARG_TEXT_P() as equals. Its postgres.h changes presented
> PG_DETOAST_DATUM_PACKED() and VARDATA_ANY() as the exceptional case. Let's
> firmly recommend PG_GETARG_TEXT_PP() over PG_GETARG_TEXT_P(); likewise for
> other ...PP() macros. This shaves cycles and brings consistency of style.

+1

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2016-10-25 15:20:12 Wraparound warning
Previous Message Noah Misch 2016-10-25 14:57:24 Recommend wrappers of PG_DETOAST_DATUM_PACKED()