From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | "Magnus Hagander" <mha(at)sollentuna(dot)net> |
Cc: | pgsql-patches(at)postgresql(dot)org |
Subject: | Re: Couple of minor fixes |
Date: | 2006-04-09 19:24:41 |
Message-ID: | 13046.1144610681@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
"Magnus Hagander" <mha(at)sollentuna(dot)net> writes:
> Attached match makes a couple of minor changes to get rid of some
> annoying compiler warnings:
> 1) backend/port/win32/sema.c declares a variable inline with the code.
> IIRC, that's only allowed in C++. Patch moves declaration to the top of
> the function.
Done.
> 2) timezone/localtime.c, transtime() has a const arcument in the
> implementation but non-const in declaration.
I did this the other way (make implementation match declaration).
I think the coding was in fact correct per spec, because const-ness
of an argument value is not part of the function signature.
> I'm also seeing a lot of signed/unsigned mismatch, but IIRC it was said
> at some point that we don't care about those.
In HEAD? They're all cleaned up according to the compilers I use.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Magnus Hagander | 2006-04-09 19:27:21 | Re: Couple of minor fixes |
Previous Message | Alvaro Herrera | 2006-04-09 19:18:04 | Re: Support Parallel Query Execution in Executor |