Re: regression test client encoding

On Fri, 2011-04-15 at 16:09 -0400, Tom Lane wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> > What I'd suggest is that we take out the bit of code in pg_regress.c
> > that overrides the client encoding.
>
> That doesn't seem like a particularly good idea in view of the recent
> changes in psql to try to intuit a default encoding from its locale
> environment. If I say --encoding in the command line, that means I want
> that encoding, not an environment-dependent one.

Actually, in light of that we might want to override PGCLIENTENCODING to
SQL_ASCII, so we get back the results in ASCII (assuming an all-ASCII
test), instead of whatever the client encoding might say, which might
not be an ASCII superset.

But I still don't see a use case for the user setting the client
encoding when the test suite is run. This can only make things worse,
not better.

> Seems to me that plpython_unicode.sql could set the client encoding if
> it wants to, regardless of what pg_regress.c might think.

Yes, that would make sense in any case.