| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org> |
| Subject: | Re: Macros for time magic values |
| Date: | 2011-03-14 08:22:59 |
| Message-ID: | 1300090979.1790.7554.camel@ebony |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, 2011-03-12 at 22:29 +0200, Peter Eisentraut wrote:
> On fre, 2011-03-11 at 12:50 -0500, Bruce Momjian wrote:
> > It has bothered me that many of our time routines use special magic
> > constants for time values, e.g. 24, 12, 60, etc.
> >
> > The attached patch changes these magic constants to macros to clarify
> > the code. I would like to apply this for 9.1 as a cleanup.
>
> I think it's much clearer with the plain numbers.
Yeh. It's not like the values 24, 12 or 60 were going to change.
--
Simon Riggs http://www.2ndQuadrant.com/books/
PostgreSQL Development, 24x7 Support, Training and Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2011-03-14 08:34:20 | Re: Shared invalidation cache messages for temporary tables |
| Previous Message | Pavel Golub | 2011-03-14 06:30:01 | Re: Multi-language glossary of PostgreSQL terms. |