| From: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
|---|---|
| To: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com> |
| Cc: | David Steele <david(at)pgmasters(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Kouhei Kaigai <kaigai(at)ak(dot)jp(dot)nec(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Amit Kapila <amit(dot)kapila(at)enterprisedb(dot)com> |
| Subject: | Re: Combining Aggregates |
| Date: | 2016-03-17 11:59:42 |
| Message-ID: | 12db0ced-2257-baf3-a97a-03d50a19d2de@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 03/17/2016 12:53 PM, David Rowley wrote:
>
...
>
> I just had a quick skim over the patch and noticed the naming
> convention you're using for the combine function is *_pl, and you have
> float8_pl. There's already a function named float8pl() which is quite
> close to what you have. I've been sticking to *_combine() for these,
> so maybe float8_combine() and float8_regr_combine() are better names.
+1 to the _combine naming convention.
regards
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Kuleshov | 2016-03-17 12:07:18 | initdb: introduce PG_CMD_PRINTF intestead of PG_CMD_PRINTF{1,2,3} |
| Previous Message | Dmitry Dolgov | 2016-03-17 11:58:55 | Re: [PATH] Jsonb, insert a new value into an array at arbitrary position |