Re: Issues cross-compiling libpq 14.x to MacOS armv8

From: Vincas Dargis <vindrg(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: pgsql-general <pgsql-general(at)lists(dot)postgresql(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz>
Subject: Re: Issues cross-compiling libpq 14.x to MacOS armv8
Date: 2021-12-02 18:36:34
Message-ID: 12a6243a-826c-e8b9-0716-61fc5aa9d229@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general

Thanks Tom!

Should we expect this fix in the next 14 patch release, or only in 15.x?

If latter, I would add this patch into Conan package itself, to make it work earlier.

On 2021-11-30 23:33, Tom Lane wrote:
> I wrote:
>> It seems like a useful test when *not* cross compiling, which is most
>> of the time. I'd just wrap that bit in
>> if test "$cross_compiling" = no; then
>
> Or actually, since we should print something, it looks like this will do:
>
> diff --git a/configure.ac b/configure.ac
> index a5c10b8d56..7257afda20 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -2287,6 +2287,8 @@ if test x"$with_ssl" = x"openssl" ; then
> AC_MSG_RESULT([OpenSSL])
> elif test x"$PORTNAME" = x"win32" ; then
> AC_MSG_RESULT([Windows native])
> +elif test x"$cross_compiling" = x"yes"; then
> + AC_MSG_RESULT([assuming /dev/urandom])
> else
> AC_MSG_RESULT([/dev/urandom])
> AC_CHECK_FILE([/dev/urandom], [], [])
>
> Off to see if I can verify that before pushing.
>
> regards, tom lane
>

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Tom Lane 2021-12-02 18:56:53 Re: Issues cross-compiling libpq 14.x to MacOS armv8
Previous Message Alan Stange 2021-12-02 16:45:21 Re: pg_upgrade question