Re: Add unistd.h to c.h

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add unistd.h to c.h
Date: 2011-03-11 17:11:40
Message-ID: 1299863412-sup-1769@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Excerpts from Heikki Linnakangas's message of vie mar 11 13:59:59 -0300 2011:

> Presumably all of these are used by something in c.h itself. At least
> strings.h is needed by memset, and stddef.h and/or stdlib.h is needed
> for size_t. I'm too lazy to check the rest, but if there are any header
> files there that are not in fact used by anything in c.h itself, they
> should be removed from c.h, rather than going further into that direction.

Yeah. FWIW I sometimes make efforts to reduce the reach of headers, for
example by removing them from other headers that don't need them. It is
quite the opposite to what you propose here.

--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2011-03-11 17:33:55 Re: Non-simultaneous file system snapshots as backups
Previous Message Heikki Linnakangas 2011-03-11 16:59:59 Re: Add unistd.h to c.h