Re: FOR KEY LOCK foreign keys

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Marti Raudsepp <marti(at)juffo(dot)org>
Cc: Noah Misch <noah(at)leadboat(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>
Subject: Re: FOR KEY LOCK foreign keys
Date: 2011-02-14 23:49:58
Message-ID: 1297726905-sup-2727@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Excerpts from Marti Raudsepp's message of lun feb 14 19:39:25 -0300 2011:
> On Fri, Feb 11, 2011 at 09:13, Noah Misch <noah(at)leadboat(dot)com> wrote:
> > The patch had a trivial conflict in planner.c, plus plenty of offsets.  I've
> > attached the rebased patch that I used for review.  For anyone following along,
> > all the interesting hunks touch heapam.c; the rest is largely mechanical.  A
> > "diff -w" patch is also considerably easier to follow.
>
> Here's a simple patch for the RelationGetIndexAttrBitmap() function,
> as explained in my last post. I don't know if it's any help to you,
> but since I wrote it I might as well send it up. This applies on top
> of Noah's rebased patch.

Got it, thanks.

> I did some tests and it seems to work, although I also hit the same
> visibility bug as Noah.

Yeah, that bug is fixed with the attached, though I am rethinking this
bit.

--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

Attachment Content-Type Size
0001-Fix-visibility-bug-and-poorly-worded-comment.patch application/octet-stream 1.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2011-02-14 23:50:21 Re: CommitFest 2011-01 as of 2011-02-04
Previous Message David E. Wheeler 2011-02-14 22:45:07 tsearch Parser Hacking