| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Macro nesting hell |
| Date: | 2015-08-13 01:27:01 |
| Message-ID: | 12977.1439429221@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2015-08-12 10:18:12 -0400, Tom Lane wrote:
>> Sounds reasonable to me. If you do this, I'll see whether pademelon
>> can be adjusted to build using the minimum macro expansion buffer
>> size specified by the C standard.
> Here's the patch attached.
Looks like you need to pay more attention to the surrounding comments:
some of them still refer to the code as a macro, and I see at least one
place that explicitly mentions double-eval hazards that this presumably
removes. (I think your previous patch re fastgetattr was also a bit weak
on the comments, btw.)
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2015-08-13 01:31:24 | Re: Parsing tuple contents |
| Previous Message | Vignesh Raghunathan | 2015-08-13 01:25:30 | Parsing tuple contents |