Re: Named restore points

On Tue, 2011-02-08 at 08:05 -0500, Robert Haas wrote:
> On Tue, Feb 8, 2011 at 2:05 AM, Jaime Casanova <jaime(at)2ndquadrant(dot)com> wrote:
> >> Finally, this is a nice feature iif we have a way to know what named restore
> >> points are available. DBAs need to take note of this list (that is not good)
> >> and the lazy ones will have a hard time to recover the right name (possibly
> >> with a xlog dump tool).
> >>
> >> So how could we store this information? Perhaps a file in
> >> $PGDATA/pg_xlog/restore_label that contains the label (and possibly the WAL
> >> location). Also it must have a way to transmit the restore_label when we add
> >> another restore point. I didn't implement this part (Jaime?) and it seems as
> >> important as the new xlog record type that is in the patch. It seems
> >> complicate but I don't have ideas. Anyone? The restore point names could be
> >> obtained by querying a function (say, pg_restore_point_names or
> >> pg_restore_point_list).
> >>
> >
> > i still think this should be a separate tool or a dba written list,
>
> I agree. Keeping track of where you've set named restore points is
> not going to be a problem with a simple solution. Which restore
> points are available is going to depend on which base backup you
> restored and what WAL files you stuffed into pg_xlog.

Yeah agreed. No need for restore_label

--
Simon Riggs http://www.2ndQuadrant.com/books/
PostgreSQL Development, 24x7 Support, Training and Services