From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
---|---|
To: | pgsql-hackers(at)postgresql(dot)org |
Subject: | pgindent and line length |
Date: | 2011-01-25 00:01:01 |
Message-ID: | 1295913661.13617.5.camel@vanquo.pezone.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Somehow, pgindent appears to have this approach to push lines that are
longer than the defined line length limit back to the left to make it
fit. That results in something like this:
printfPQExpBuffer(&buf,
"SELECT n.nspname as \"%s\",\n"
" p.proname AS \"%s\",\n"
" pg_catalog.format_type(p.prorettype, NULL) AS \"%s\",\n",
gettext_noop("Schema"),
gettext_noop("Name"),
gettext_noop("Result data type"));
where the third line of the string was moved to the left.
I don't think this behavior is useful. If the line is too long and
cannot be split, then it is still more useful to be able locate the
start of the line in an expected position than to have the end of the
line on the hypothetical screen. You'll have to scroll right anyway
because there are usually lines that are going to be too long anyway.
Can we get rid of this behavior?
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2011-01-25 00:01:13 | Re: Patch to add a primary key using an existing index |
Previous Message | Kevin Grittner | 2011-01-24 23:36:39 | SSI future enhancement: de facto read only optimization |