Re: pl/python refactoring

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Jan Urbański <wulczer(at)wulczer(dot)org>
Cc: Postgres - Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pl/python refactoring
Date: 2011-01-22 20:53:41
Message-ID: 1295729621.1770.3.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On tor, 2011-01-20 at 03:16 +0100, Jan Urbański wrote:
> Here's an updated patch series for PL/Python refactoring. It was 16
> patches at first, 8 are committed, 1 got dropped, so we're down to 7.

> Refactor PLy_spi_prepare to save two levels of indentation.
>
> Instead of checking if the arglist is NULL and then if its length is
> 0, do it in one step, and outside of the try/catch block.

Why is it a good idea to do the PLy_malloc calls outside of the
try/catch block? Also, why call them when nargs is 0?

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dimitri Fontaine 2011-01-22 21:25:26 Re: FOR KEY LOCK foreign keys
Previous Message Peter Eisentraut 2011-01-22 20:14:36 pgsql: Get rid of the global variable holding the error state