| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com> |
| Cc: | Jan Urbański <wulczer(at)wulczer(dot)org>, Postgres - Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pl/python refactoring |
| Date: | 2011-01-20 20:38:33 |
| Message-ID: | 1295555913.27153.2.camel@vanquo.pezone.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On ons, 2011-01-19 at 10:06 +0900, Hitoshi Harada wrote:
> - This is not in the patch, but around line 184 "vis versa" in comment
> seems like typo.
Fixed.
> - A line break should be added before PLy_add_exception() after "static void"
I'll add that when I get to the patch.
> - This is also not in the patch, but the comment
> /* these should only be called once at the first call
> * of plpython_call_handler. initialize the python interpreter
> * and global data.
> */
> is bogus. PLy_init_interp() is called in _PG_init().
Fixed.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2011-01-20 20:47:52 | Re: REVIEW: EXPLAIN and nfiltered |
| Previous Message | Kevin Grittner | 2011-01-20 20:36:19 | SSI patch version 13 |