From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
---|---|
To: | Magnus Hagander <magnus(at)hagander(dot)net> |
Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pg_basebackup for streaming base backups |
Date: | 2011-01-18 13:26:06 |
Message-ID: | 1295357056-sup-9992@alvh.no-ip.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Excerpts from Magnus Hagander's message of mar ene 18 08:40:50 -0300 2011:
> On Tue, Jan 18, 2011 at 10:49, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> > + fprintf(stderr, _("%s: could not write to file '%s': %m\n"),
> >
> > %m in fprintf is portable?
>
> Hmm. I just assumed it was because we use it elsewhere, but I now see
> we only really use it for ereport() stuff. Bottom line is, I don't
> know - perhaps it needs to be changed to use strerror()?
Some libc's (such as glibc) know about %m, others presumably don't (it's
a GNU extension, according to my manpage). ereport does the expansion
by itself, see expand_fmt_string(). Probably just using strerror() is
the easiest.
--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2011-01-18 13:35:58 | Re: ToDo List Item - System Table Index Clustering |
Previous Message | Dimitri Fontaine | 2011-01-18 13:25:26 | Re: REVIEW: Extensions support for pg_dump |