| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Craig Ringer <craig(at)postnewspapers(dot)com(dot)au>, Elliot Chance <elliotchance(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: C++ keywords in headers (was Re: [GENERAL] #include <funcapi.h>) |
| Date: | 2010-12-27 16:12:54 |
| Message-ID: | 1293466319-sup-2446@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-general pgsql-hackers |
Excerpts from Peter Eisentraut's message of lun dic 27 12:54:16 -0300 2010:
> On sön, 2010-12-26 at 12:31 -0500, Tom Lane wrote:
> > We did clean up C++ keyword uses in the header files in 9.0, but your
> > report shows it's already gotten broken again. I'm disinclined to fix
> > it unless someone steps up to create an automated test that will get
> > run reasonably often. We had that discussion when the patch to rename
> > keyword-named fields was proposed, and nothing got done, and the
> > current state of affairs is the entirely predictable result.
>
> src/tools/pginclude/cpluspluscheck
>
> What's missing is to automate this, but it's unclear in what context,
> and perhaps also to what extend this should be a hard requirement.
Maybe we could mention it in src/tools/RELEASE_CHANGES
--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Rob Marjot | 2010-12-27 16:31:26 | CONSTRAINT does not show when applying a EXCLUDE constraint |
| Previous Message | Peter Eisentraut | 2010-12-27 15:54:16 | Re: C++ keywords in headers (was Re: [GENERAL] #include <funcapi.h>) |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2010-12-27 16:13:03 | estimating # of distinct values |
| Previous Message | Simon Riggs | 2010-12-27 16:04:40 | Re: Reduce lock levels for ADD and DROP COLUMN |