From: | Andreas Karlsson <andreas(at)proxel(dot)se> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | PG Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Tab completion for ALTER ... SET SCHEMA |
Date: | 2010-12-18 02:30:11 |
Message-ID: | 1292639411.27475.14.camel@jansson |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, 2010-12-17 at 21:20 -0500, Robert Haas wrote:
> On Fri, Dec 17, 2010 at 9:14 PM, Andreas Karlsson <andreas(at)proxel(dot)se> wrote:
> > What it does is gets rid of the incorrect completion which comes from
> > the completion rule for "SET foo TO bar" by adding the correct
> > completion for "SET SCHEMA" higher up in the completion function.
> >
> > So instead of an incorrect completion we get the correct one.
>
> But that's not necessarily wrong, if "foo" happens to be the name of a GUC.
Agreed, which is why I made the new rule only match
ALTER x x SET SCHEMA
while the rest will fall down and match
SET
. So I should be safe since SCHEMA is a reserved words. When I think of
it I may even have be unnecessary to require the ALTER verb.
Regards,
Andreas
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2010-12-18 02:45:52 | Re: Tab completion for ALTER ... SET SCHEMA |
Previous Message | Robert Haas | 2010-12-18 02:20:57 | Re: Tab completion for ALTER ... SET SCHEMA |